Fixed lengths of functions #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed length of 3 functions so that they do not take more than 50 lines by separating them to smaller blocks. Also found and fixed a bug in SideBySide renderer, where it would print wrong line count for modified lines on the right side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed length of 3 functions so that they do not take more than 50 lines by separating them to smaller blocks.
Also found and fixed a bug in SideBySide renderer, where it would print wrong line count for modified lines on the right side.
I failed to change the render method in Diff_Renderer_Text_Context, because there was nothing that made logical sense to pull out to separate function and I did not want to remove empty lines as to not break readability of the code.